Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1.x] Fix XSS in some dashboards queries (#2785) #2801

Merged
merged 2 commits into from
Feb 19, 2023

Conversation

deniszh
Copy link
Member

@deniszh deniszh commented Feb 19, 2023

Backport

This will backport the following commits from master to 1.1.x:

Questions ?

Please refer to the Backport tool documentation

* prevent xss on time range text fields

* prevent xss on dashbord queries

(cherry picked from commit 2f178f4)

# Conflicts:
#	webapp/graphite/errors.py
#	webapp/tests/base.py
@codecov-commenter
Copy link

Codecov Report

Base: 76.05% // Head: 76.07% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (a6f3c27) compared to base (9585590).
Patch coverage: 83.33% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##            1.1.x    #2801      +/-   ##
==========================================
+ Coverage   76.05%   76.07%   +0.01%     
==========================================
  Files          88       88              
  Lines        9644     9681      +37     
  Branches     2061     2067       +6     
==========================================
+ Hits         7335     7365      +30     
- Misses       2049     2056       +7     
  Partials      260      260              
Impacted Files Coverage Δ
webapp/graphite/util.py 80.00% <60.00%> (-0.82%) ⬇️
webapp/graphite/errors.py 93.58% <78.57%> (-3.52%) ⬇️
webapp/graphite/dashboard/views.py 99.30% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@deniszh deniszh merged commit 2225774 into graphite-project:1.1.x Feb 19, 2023
@deniszh deniszh deleted the backport/1.1.x/pr-2785 branch February 19, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants